fix: cap maximum disconnect timeout #3810
Merged
+107
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noellie-velez
changed the title
…-Technologies/com.unity.netcode.gameobjects into fix/cap-maximum-disconnect-timeout
Contributor
|
A more appropriate way to check for overflow would be to use a checked statement. Also while we're modifying that code, we might as well handle the case of the disconnect timeout being 0. In newer versions of UTP, this is now valid and will disable the timeout entirely (which I guess is what users were trying to achieve by setting it very high to begin with). Setting it to the maximum maximum value in that situation makes sense. |
EmandM
approved these changes
Dec 17, 2025
|
|
||
| ### Changed | ||
|
|
||
| - If m_DisconnectTimeoutMS is set to 0 in the Editor for Unity Transport, the timeout will be entirely disabeled. (#3810) |
Member
There was a problem hiding this comment.
This is a Unity Transport change that went out a while ago. We don't need to add it to our changelog.
Suggested change
| - If m_DisconnectTimeoutMS is set to 0 in the Editor for Unity Transport, the timeout will be entirely disabeled. (#3810) |
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed issue where maxCapacity calculation overflows if a developer sets a very, very high (large) m_DisconnectTimeoutMS in the Editor for Unity Transport. (#3810) |
Member
There was a problem hiding this comment.
This changelog entry has a bit too much technical detail. We're more interested in explaining what's changed for users 😄
Suggested change
| - Fixed issue where maxCapacity calculation overflows if a developer sets a very, very high (large) m_DisconnectTimeoutMS in the Editor for Unity Transport. (#3810) | |
| - Fixed an integer overflow that occurred when configuring a large disconnect timeout with Unity Transport. (#3810) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
MTTB-1671
fixes: #3717
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports